rewrite mapreduce upsert tests with async/await#9176
Open
emilygilberts wants to merge 1 commit intoapache:masterfrom
Open
rewrite mapreduce upsert tests with async/await#9176emilygilberts wants to merge 1 commit intoapache:masterfrom
emilygilberts wants to merge 1 commit intoapache:masterfrom
Conversation
janl
reviewed
Feb 20, 2026
Member
There was a problem hiding this comment.
this looks good overall, I’m just wondering if it would make sense to DRY out the get and put functions a little bit, it’s three lines each when the only difference is the what the promise resolves with.
Spitballing here:
instead of
const res = await upsert(
{
get: function () {
return Promise.reject({ status: 404 });
},
put: function () {
return Promise.resolve({ rev: 'abc' });
},
},
'foo',
function () {
return { difference: "something" };
},
);function makeFun (action, value) {
return function() { return Promise[action](value) };
}
// [...]
const res = await upsert(
{
get: makeFun('resolve', {status: 404}),
put: makeFun('reject', { rev: 'abc' }),
},
'foo',
function () { return { difference: "something" };
},
);Might be too fancy, feel free to shoot me down :)
| it('should throw an error if the doc errors', async function () { | ||
| try { | ||
| await upsert( | ||
| { |
Member
There was a problem hiding this comment.
just a style nit, but I’d be okay with having the opening curlies start with the method: upsert({ to save a mostly empty line
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mapreduce.js-upsertusingasync/await(left the
mapreduce.js-utilstests as they are, because they are more readable & straightforward with the current syntax)