Skip to content

Conversation

@alxndrsn
Copy link
Contributor

@alxndrsn alxndrsn commented Mar 24, 2024

@alxndrsn
Copy link
Contributor Author

alxndrsn commented Apr 9, 2024

Should browser-adapter tests also be dropped?

@garethbowen
Copy link
Contributor

Should browser-adapter tests also be dropped?

Why? Do they hit pouch-server too?

@alxndrsn
Copy link
Contributor Author

alxndrsn commented Apr 9, 2024

Should browser-adapter tests also be dropped?

Why? Do they hit pouch-server too?

They use pouchdb-express-router. I think I was confused - there are 3 pouch-based servers currently referenced from this repo:

  1. pouchdb-server: https://github.com/pouchdb/pouchdb-server
  2. pouchdb-express-router: https://github.com/pouchdb/pouchdb-express-router
  3. express-pouchdb-minimum: https://github.com/pouchdb/pouchdb-server/tree/master/packages/node_modules/express-pouchdb, via https://github.com/pouchdb/pouchdb/blob/db193f5c1f9f531020f375c0422636948b4c8e5f/tests/misc/express-pouchdb-minimum-for-pouchdb.js

1 & 3 are based on pouchdb-server; #2 seems to be separate.

@alxndrsn
Copy link
Contributor Author

here's a quick summary of the most recent failures seen on master as per 2024-04-09:

{
  "couchdb-nodejs": {
    "_total_errors": 2,
    "3.1, 16, npm test": 2
  },
  "pouchdb-server": {
    "_total_errors": 17,
    "node, npm test": 12,
    "webkit, npm test": 1,
    "chromium, npm test": 2,
    "firefox, npm test": 2
  },
  "browser-adapter": {
    "_total_errors": 69,
    "chromium, idb, npm test": 1,
    "webkit, idb, npm test": 7,
    "webkit, indexeddb, npm test": 5,
    "webkit, memory, npm test": 16,
    "firefox, idb, npm test": 6,
    "firefox, memory, npm test": 17,
    "firefox, indexeddb, npm test": 16,
    "chromium, indexeddb, npm test": 1
  },
  "nodejs": {
    "_total_errors": 34,
    "16, CLIENT=firefox npm run test-webpack": 18,
    "14, CLIENT=firefox npm run test-webpack": 16
  },
  "nodejs-adapter": {
    "_total_errors": 5,
    "14, memory, npm test": 2,
    "16, leveldb, npm test": 1,
    "16, memory, npm test": 2
  },
  "couchdb-browser": {
    "_total_errors": 1,
    "2.3, webkit, npm test": 1
  }
}

browser-adapter tests run against pouchdb-express-router, not pouchdb-server.

Dropping both of these might be an option, but it's unclear if test flake is actually:

  1. in pouch core code
  2. in pouch adapter code
  3. in pouch test code
  4. in server implementations

@alxndrsn alxndrsn closed this Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants