Skip to content

(#8594) - fix plugin override built-in methods - Take 2 #8739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
louwers wants to merge 3 commits into from
Closed

(#8594) - fix plugin override built-in methods - Take 2 #8739

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3dca62f
(#8594) - plugin override built-in methods
EthanDawes May 1, 2023
dd9e3f2
Merge branch 'master' into master
garethbowen Aug 27, 2023
c1a5e41
Implement test
louwers Aug 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/node_modules/pouchdb-core/src/adapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,7 @@ function attachmentNameError(name) {

class AbstractPouchDB extends EventEmitter {
_setup() {
var pluginPrototype = Object.getPrototypeOf(this);
this.post = adapterFun('post', function (doc, opts, callback) {
if (typeof opts === 'function') {
callback = opts;
Expand Down Expand Up @@ -920,6 +921,13 @@ class AbstractPouchDB extends EventEmitter {
Promise.all(deletedMap).then(destroyDb, callback);
});
}).bind(this);

// Re-add plugin methods that may have been overridden
for (var key in pluginPrototype) {
if (this[key] !== pluginPrototype[key]) {
this[key] = pluginPrototype[key];
}
}
}

_compact(opts, callback) {
Expand Down
19 changes: 19 additions & 0 deletions tests/integration/test.basics.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1205,6 +1205,25 @@ adapters.forEach(function (adapter) {
});
}

it('8594, PouchDB.plugin() can override core methods', function (done) {
const pouchBulkDocs = PouchDB.prototype.bulkDocs; // original bulkDocs
let called = false;
PouchDB.plugin({ // override
bulkDocs: function (docs, options, callback) {
called = true;
return pouchBulkDocs.call(this, docs, options, callback);
}
});
const db = new PouchDB("test");
// will error, but we don't care about the error
// just checking if called === true so that
// bulkDocs indeed got overridden
db.bulkDocs().catch(function () {
called.should.equal(true);
done();
});
});

if (typeof process !== 'undefined' && !process.browser) {
it('#5471 PouchDB.plugin() should throw error if passed wrong type or empty object', function () {
(function () {
Expand Down