Skip to content

Conversation

@cetsupport
Copy link

@cetsupport cetsupport commented May 27, 2022

Only need disconnect the mrview with right database name, in case multiple databases running.

Issue originally reported here: pubkey/rxdb#3813.

PR with detail reproduce procedure is here: #8513

Only need disconnect the mrview with right database name, in case multiple databases running.
@maximerety
Copy link

maximerety commented Aug 19, 2022

Thanks @cetsupport and @pubkey for reporting this.

After upgrading from PouchDB 7.2.2 to 7.3.0, I noticed the same problem in several projects where I use several databases simultaneously.

Two inappropriate behaviors occur consistently:

  • Either unexpectedly receiving Error: database is closed
  • Or process hanging indefinitely

Both behaviors are fixed when manually applying the patch from this MR, so I'd be really glad to see it merged and prioritized for the next patch release 🙏

@maximerety
Copy link

maximerety commented Nov 25, 2022

I just saw that version 7.3.1 was released but did not include this fix.

Could it be prioritized for the next patch release or is extra work needed before? If so, how can we help?

@AlbaHerrerias, as last person having published a release, would you maybe have an update about this issue?

Thanks in advance.

@garethbowen
Copy link
Contributor

@maximerety One thing that would help get this merged is having a unit test in the PR. Could you look at adding that, than I can help get this reviewed.

@PaulMest
Copy link
Contributor

PaulMest commented Dec 7, 2022

@maximerety One thing that would help get this merged is having a unit test in the PR. Could you look at adding that, than I can help get this reviewed.

I've included both in my PR: #8513.

@garethbowen
Copy link
Contributor

Merged in #8513

@maximerety
Copy link

maximerety commented Dec 13, 2022

@maximerety One thing that would help get this merged is having a unit test in the PR. Could you look at adding that, than I can help get this reviewed.

Hi @garethbowen,

Thanks for your answer.

I'm sorry I didn't respond sooner... I tried to push the tests for this issue, then I started having too many questions making me wonder if I was on the right track.

I have created an issue summarizing my concerns here: #8574 (+ #8575)

If you have time to have a look someday, it would be greatly appreciated.

@cetsupport / @PaulMest Thanks again for the fix. If you have time to give your opinion on #8574, I would gladly take it under advisement.

@cetsupport
Copy link
Author

Got it, will check it later today or tomorrow.

BR//Jeff

@cetsupport
Copy link
Author

Sorry I leave for vacation couple of days, please let me know if I need review it or not? @maximerety

@maximerety
Copy link

Sorry I leave for vacation couple of days, please let me know if I need review it or not? @maximerety

@cetsupport Thank you for taking the time to revisit this issue. I would certainly appreciate your opinion on #8574 (+ #8575) as it has received little feedback, albeit positive, to date.

samir-mahendra added a commit to powwowinc/pouchdb that referenced this pull request Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants