Add API to update segment ZK metadata without uploading - #19180
Open
goutamadwant wants to merge 1 commit into
Open
Add API to update segment ZK metadata without uploading#19180goutamadwant wants to merge 1 commit into
goutamadwant wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #19180 +/- ##
============================================
+ Coverage 66.62% 66.64% +0.01%
- Complexity 1423 1425 +2
============================================
Files 3443 3443
Lines 218577 218636 +59
Branches 34792 34798 +6
============================================
+ Hits 145624 145703 +79
+ Misses 61218 61197 -21
- Partials 11735 11736 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10458
What this PR does
PUT /segments/{tableNameWithType}/{segmentName}/metadataAPI for updating the segment ZK metadata custom map.If-Matchand uses the ZK record version for compare-and-set protection.Backward compatibility
The endpoint is additive. Existing upload behavior is unchanged for modified segments, and older controllers continue to work through the fallback path.
Tests
PinotSegmentRestletResourceTestBaseSingleSegmentConversionExecutorTestpinot-common,pinot-controller, andpinot-minion-builtin-tasks