Return server readiness only after query serving starts - #19178
Open
goutamadwant wants to merge 1 commit into
Open
Return server readiness only after query serving starts#19178goutamadwant wants to merge 1 commit into
goutamadwant wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #19178 +/- ##
============================================
- Coverage 66.62% 66.62% -0.01%
Complexity 1423 1423
============================================
Files 3443 3443
Lines 218577 218579 +2
Branches 34792 34792
============================================
- Hits 145624 145621 -3
- Misses 61218 61225 +7
+ Partials 11735 11733 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Jackie-Jiang
reviewed
Aug 7, 2026
Jackie-Jiang
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the contribution.
Unfortunately this solution is still not good enough. There is a delay for broker to get the server config change callback and add it to the routing.
We need to find a way to ensure broker already add the server to the routing table
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IS_SHUTDOWN_IN_PROGRESSis clearedWhy
During startup,
ServiceStatuscan becomeGOODbefore the query server is started and before brokers can route queries back to the server. This allowed/healthand/health/readinessto return200too early during rolling restarts.The health resource uses the existing local readiness signal instead of reading Helix on every probe.
This addresses item 1 of #16565. The broker external-view watermark described in item 2 remains out of scope.
Testing
./mvnw -pl pinot-server -am -Dtest=HealthCheckResourceTest,AccessControlTest -Dsurefire.failIfNoSpecifiedTests=false test./mvnw spotless:apply -pl pinot-server./mvnw license:format -pl pinot-server./mvnw checkstyle:check -pl pinot-server./mvnw license:check -pl pinot-server./mvnw test-compile -pl pinot-server -am -Dmaven.compiler.showDeprecation=true -Dmaven.compiler.showWarnings=true '-Dmaven.compiler.compilerArgs=-Xlint:all'