Support UUID literals in request context - #19155
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19155 +/- ##
=========================================
Coverage 65.78% 65.78%
Complexity 1423 1423
=========================================
Files 3441 3441
Lines 218303 218324 +21
Branches 34728 34739 +11
=========================================
+ Hits 143609 143635 +26
+ Misses 63119 63104 -15
- Partials 11575 11585 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
xiangfu0
marked this pull request as ready for review
August 4, 2026 17:37
Jackie-Jiang
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
DataType.UUIDtoPinotDataType.UUIDinLiteralContextjava.util.UUIDvalues through the existing binary literal fieldCAST(... AS UUID)foldingWhy
PR #18872 currently carries UUID literal plumbing alongside server-side predicate and transform changes. This extracts that plumbing into a small prerequisite PR and keeps the existing request wire format unchanged.
Validation
LiteralContextTestandRequestUtilsTest: 33 tests, 0 failuresspotless:apply,license:format,checkstyle:check, andlicense:checkonpinot-common