This PR adds small Helm chart improvements for deployment flexibility while keeping backward compatibility by default#18793
Conversation
| securityContext: | ||
| {{- toYaml .Values.controller.securityContext | nindent 10 }} | ||
| image: "{{ .Values.image.repository }}:{{ .Values.image.tag }}" | ||
| image: "{{ .Values.minionImage.repository | default .Values.image.repository }}:{{ .Values.minionImage.tag | default .Values.image.tag }}" |
There was a problem hiding this comment.
why use minionImage for controller?
There was a problem hiding this comment.
If I remember correctly Minions and controller are tied together, so controller should know about new minions to properly schedule them for execution, it's ok to deploy the same custom image with minions to all components, we just isolated it so we can do deploy without rolling all servers (servers do not need to know about minion plugins)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #18793 +/- ##
============================================
- Coverage 64.80% 64.79% -0.02%
Complexity 1309 1309
============================================
Files 3380 3380
Lines 209860 209860
Branches 32874 32874
============================================
- Hits 135998 135977 -21
- Misses 62909 62926 +17
- Partials 10953 10957 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Summary
This PR adds small Helm chart improvements for deployment flexibility while keeping backward compatibility by default.
Changes
Add optional namespace creation:
Add workload-level annotations support for:
Add optional minionImage override with fallback to global image
Minor whitespace cleanup in helm/pinot/templates/server/configmap.yaml
({{ if }} -> {{- if }})Backward Compatibility
Defaults preserve existing behavior: