Skip to content

This PR adds small Helm chart improvements for deployment flexibility while keeping backward compatibility by default#18793

Open
davidballano wants to merge 2 commits into
apache:masterfrom
davidballano:helm-upstream-customizations
Open

This PR adds small Helm chart improvements for deployment flexibility while keeping backward compatibility by default#18793
davidballano wants to merge 2 commits into
apache:masterfrom
davidballano:helm-upstream-customizations

Conversation

@davidballano

@davidballano davidballano commented Jun 17, 2026

Copy link
Copy Markdown

Summary

This PR adds small Helm chart improvements for deployment flexibility while keeping backward compatibility by default.

Changes

  • Add optional namespace creation:

    • namespace.create (default false)
    • new template namespace.yaml
  • Add workload-level annotations support for:

    • controller, broker, server, minion, minion-stateless
  • Add optional minionImage override with fallback to global image

    • applied to controller, minion, and minion-stateless workloads
  • Minor whitespace cleanup in helm/pinot/templates/server/configmap.yaml ({{ if }} -> {{- if }})

Backward Compatibility

Defaults preserve existing behavior:

namespace.create: false
annotations: {}
minionImage: {} (falls back to image)

@davidballano davidballano changed the title Helm upstream customizations This PR adds small Helm chart improvements for deployment flexibility while keeping backward compatibility by default Jun 17, 2026
@xiangfu0 xiangfu0 added the helm Related to Helm chart configuration label Jun 18, 2026
securityContext:
{{- toYaml .Values.controller.securityContext | nindent 10 }}
image: "{{ .Values.image.repository }}:{{ .Values.image.tag }}"
image: "{{ .Values.minionImage.repository | default .Values.image.repository }}:{{ .Values.minionImage.tag | default .Values.image.tag }}"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why use minionImage for controller?

@davidballano davidballano Jun 18, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I remember correctly Minions and controller are tied together, so controller should know about new minions to properly schedule them for execution, it's ok to deploy the same custom image with minions to all components, we just isolated it so we can do deploy without rolling all servers (servers do not need to know about minion plugins)

@codecov-commenter

codecov-commenter commented Jun 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.79%. Comparing base (40af905) to head (22df244).
⚠️ Report is 20 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #18793      +/-   ##
============================================
- Coverage     64.80%   64.79%   -0.02%     
  Complexity     1309     1309              
============================================
  Files          3380     3380              
  Lines        209860   209860              
  Branches      32874    32874              
============================================
- Hits         135998   135977      -21     
- Misses        62909    62926      +17     
- Partials      10953    10957       +4     
Flag Coverage Δ
custom-integration1 100.00% <ø> (ø)
integration 100.00% <ø> (ø)
integration1 100.00% <ø> (ø)
integration2 0.00% <ø> (ø)
java-21 64.79% <ø> (-0.02%) ⬇️
temurin 64.79% <ø> (-0.02%) ⬇️
unittests 64.79% <ø> (-0.02%) ⬇️
unittests1 56.98% <ø> (-0.02%) ⬇️
unittests2 37.26% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

helm Related to Helm chart configuration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants