[jdbc] Implement real paging and pattern filtering for listViewsPaged.#8817
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
JdbcCatalog.listViewsPaged previously returned all views in a single page and ignored paging/pattern parameters. This PR implements the real behavior:
maxResults + 1 is fetched so the existence of a next page is detected without a separate count.
Design notes:
all-objects fallback) continue to throw UnsupportedOperationException on a pattern rather than silently returning unfiltered results. The Catalog javadoc for supportsListByPattern() is updated to document
that a single method may honor a pattern by overriding it directly, independent of the flag.
Tests
Added testListViewsPaged and testListViewDetailsPaged to JdbcCatalogTest covering: