[core][spark] Flatten scored global index result unions#8809
Open
QuakeWang wants to merge 1 commit into
Open
Conversation
Repeated ScoredGlobalIndexResult.or calls build a linear ScoreGetter chain. Aggregating many split results can recurse through the full chain during top-k selection or serialization and overflow the stack while retaining intermediate bitmaps. Materialize multi-result unions into a flat row-ID and score result, use it across common, data-evolution, and Spark aggregation paths, and add regression coverage for large split counts. Signed-off-by: QuakeWang <wangfuzheng0814@foxmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Repeated
ScoredGlobalIndexResult.orcalls build a linearScoreGetterchain. When aggregating many index splits, top-k selection or serialization may recurse through thousands of getters, causingStackOverflowErrorand retaining intermediate bitmaps.Add a bulk
mergeoperation that materializes a flat row-ID/score result, and use it across common, data-evolution, and Spark aggregation paths while preserving first-result score precedence.Tests
ScoredGlobalIndexResultTestSparkDataEvolutionVectorReadTest