[mosaic] Clean up reader resources on construction failure#8144
Open
QuakeWang wants to merge 1 commit into
Open
[mosaic] Clean up reader resources on construction failure#8144QuakeWang wants to merge 1 commit into
QuakeWang wants to merge 1 commit into
Conversation
Signed-off-by: QuakeWang <wangfuzheng0814@foxmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
MosaicReaderFactorycreates aMosaicInputFileAdapterbefore constructingMosaicRecordsReader. IfMosaicRecordsReaderfailed during construction, callers could not receive the reader instance and therefore could not close it.The old constructor only closed the allocator when
MosaicReader.openthrew anException. It did not close the input adapter, did not handleErrorfailures such as native loading errors, and did not clean up if initialization failed after the native reader had already been created.This patch initializes reader resources through local variables and assigns final fields only after construction succeeds. On construction failure, it closes the created native reader, allocator, and input adapter while preserving the original exception.
Tests
mvn -pl paimon-mosaic -am -Pfast-build -DfailIfNoTests=false -Dtest=MosaicRecordsReaderTest testmvn -pl paimon-mosaic -am -DfailIfNoTests=false -Dtest=MosaicRecordsReaderTest test