[spark] Case-insensitive field matching when casting nested struct on write.#7743
Open
JunRuiLee wants to merge 1 commit intoapache:masterfrom
Open
[spark] Case-insensitive field matching when casting nested struct on write.#7743JunRuiLee wants to merge 1 commit intoapache:masterfrom
JunRuiLee wants to merge 1 commit intoapache:masterfrom
Conversation
… write
Writing BY NAME into a Paimon table whose nested struct field names
differ from the source only in case failed with "field does not exist",
because addCastToStructByName used case-sensitive lookups and ignored
spark.sql.caseSensitive.
- Use conf.resolver for source-field lookup and the extra-field guard.
- Reject ambiguous source matches and conflicting target field names
under the active resolver, mirroring the top-level column-name-conflict
behavior.
- Add a struct length check to schemaCompatible so paimonWriteResolved
no longer short-circuits past the new nested validations when source
and target struct arities differ.
- Stop casting the intermediate struct before recursing; Spark casts
structs positionally, which would silently misread fields when the
nested layout is reordered. Descend over the original source layout
and cast only at leaf fields.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
When writing BY NAME into a Paimon table whose nested struct field names differ from the source only in case, the insert fails with "field does not exist", because the lookup is case-sensitive and ignores spark.sql.caseSensitive.
Example:
Tests