Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
File index V1 stores index entries before the payloads and uses 32-bit payload positions. This change adds an optional V2 container format that writes payloads before a footer and uses 64-bit start positions and lengths.
Readers remain compatible with V1 and V2. Writers select the format through
file-index.format.version, which defaults to V1. Backend payload APIs remain byte-array based in this stage, and readers reject an individual payload whose length exceedsInteger.MAX_VALUE; streaming payload reads and writes will be handled separately.Tests
Not run yet; compilation and tests were intentionally deferred for this draft.