[release] Fix Maven staging upload from reactor root - #10004
Open
XiaoHongbo-Hope wants to merge 1 commit into
Open
XiaoHongbo-Hope wants to merge 1 commit into
XiaoHongbo-Hope wants to merge 1 commit into
Conversation
XiaoHongbo-Hope
marked this pull request as ready for review
September 20, 2026 09:22
JingsongLi
reviewed
Sep 21, 2026
JingsongLi
left a comment
Contributor
There was a problem hiding this comment.
Requirement fit: SUPPORTED (triage: GO)\nImplementation: CLEAN\n\nThis prevents a dangerous release false success where the staging script reports success but uploads nothing. The non-recursive Maven invocation executes the Nexus goal once at the reactor root, and the fake Maven/GPG tests retain close, release, override, and failure behavior without external side effects. No actionable P0/P1/P2 issue found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Maven release staging script can silently upload nothing when it is run from Paimon's multi-module repository root. The Nexus staging plugin defers a direct CLI invocation to the last reactor project, but that project is skipped in this invocation, so Maven reports
BUILD SUCCESSwithout connecting to Nexus or creating a staging repository.Add Maven's
-Noption so the root project is the only reactor project anddeploy-staged-repositoryexecutes exactly once. All existing command overrides and staging safety settings remain unchanged.The regression test uses fake Maven and GPG executables. It verifies one non-recursive staging invocation, the configurable arguments, and the existing close/release/failure behavior without contacting Nexus, uploading artifacts, or signing files.
Validation:
python3.11 -m unittest tools.ci.test_deploy_maven_repositorypython3.11 -m unittest discover -s tools/ci -p 'test_*.py'bash -n tools/releasing/deploy_maven_repository.shgit diff --check