Conversation
Zouxxyy
marked this pull request as draft
September 20, 2026 08:47
Zouxxyy
marked this pull request as ready for review
September 20, 2026 09:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
PyPaimon rejects Arrow
large_stringinputs even when their values fit the table's existingSTRINGrepresentation. This change accepts the logical type and normalizes string layouts at the core write boundary.stringandlarge_stringto PaimonSTRING, including nested schema fields.large_stringtostringbefore routing, buffering or writing. Apply the same preparation to Table, RecordBatch, precomputed-bucket and postpone writes.Only string layouts are normalized; field names, nullability, metadata, numeric types and BYTES/BLOB semantics are retained. The buffer and read implementations are unchanged. Arrow's native nested-cast and offset limits still apply: unsupported input is rejected before reaching a data writer. This change does not add support for oversized string arrays or
string_view, and does not change dependency versions.Tests
large_string: all 4 rows roundtripped unchanged.git diff --checkpassed.