Skip to content

HDDS-16385. Minor cleanups in NodeDecommissionManager #11211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
navinko wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −4
Open

HDDS-16385. Minor cleanups in NodeDecommissionManager #11211

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions ...dds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/NodeDecommissionManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
import java.net.URISyntaxException;
import java.net.UnknownHostException;
import java.util.ArrayList;
import java.util.Collections;
import java.util.Comparator;
import java.util.LinkedList;
import java.util.List;
Expand Down Expand Up @@ -106,7 +105,7 @@ private void parseHostname() throws InvalidHostStringException {

if (this.hostname == null) {
throw new InvalidHostStringException("The string " + rawHostname +
" does not contain a value hostname or hostname:port definition");
" does not contain a valid hostname or hostname:port definition");
}
} catch (URISyntaxException e) {
throw new InvalidHostStringException(
Expand Down Expand Up @@ -537,8 +536,7 @@ public synchronized void startMaintenance(DatanodeDetails dn, int endInHours)

private synchronized boolean checkIfMaintenancePossible(List<DatanodeDetails> dns, List<DatanodeAdminError> errors) {
int numMaintenance = dns.size();
List<DatanodeDetails> validDns = dns.stream().collect(Collectors.toList());
Collections.copy(validDns, dns);
List<DatanodeDetails> validDns = new ArrayList<>(dns);
int inServiceTotal = nodeManager.getNodeCount(NodeStatus.inServiceHealthy());
for (DatanodeDetails dn : dns) {
try {
Expand Down