Skip to content

HDDS-15966. Fix flaky TestScmHAFinalization#testSnapshotFinalization #11200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
errose28 wants to merge 6 commits into
base: HDDS-14496-zdu
Choose a base branch
from
+7 −3
Open

HDDS-15966. Fix flaky TestScmHAFinalization#testSnapshotFinalization #11200

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7a5273c
Work around DB failure, add logging for safemode failure
errose28 Sep 2, 2026
c485f28
Revert "Work around DB failure, add logging for safemode failure"
errose28 Sep 2, 2026
3b476c5
Gracefully handle snapshot install in-progress while checking DB for …
errose28 Sep 2, 2026
b4ca754
Remove safemode exit as criteria
errose28 Sep 2, 2026
4779634
Add more specific logs
errose28 Sep 3, 2026
85b2b98
Revert "Add more specific logs"
errose28 Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions ...e/integration-test/src/test/java/org/apache/hadoop/hdds/upgrade/HddsUpgradeTestUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,16 +133,20 @@ private static boolean isScmFinalized(StorageContainerManager scm, boolean waitF
try {
dbKeyFlushed = scm.getScmMetadataStore().getMetaTable().get(OzoneConsts.APPARENT_VERSION_KEY) != null;
} catch (RocksDatabaseException | CodecException e) {
throw new RuntimeException(e);
// The metadata RocksDB is briefly closed while a Ratis snapshot install reloads the checkpoint.
// Treat that as "not finalized yet" and let waitFor retry rather than failing the test.
LOG.info("SCM {} metadata DB not readable yet (snapshot install in progress?), will retry.",
scm.getSCMNodeId(), e);
}

LOG.info("Waiting for SCM {} (leader? {}) to finalize.\n" +
"Exited safemode? {}\n" +
"Exited safemode? (not required) {}\n" +
"version manager finalized? {}\n" +
"DB key flushed? {}\n" +
"Requiring DB key to flush? {}",
scm.getSCMNodeId(), scm.checkLeader(), exitedSafemode, isFinalized, dbKeyFlushed, waitForDBKeyFlush);

return exitedSafemode && isFinalized && (!waitForDBKeyFlush || dbKeyFlushed);
// Safemode exit status is included for logging purposes, but SCMs can still finalize while in safemode.
return isFinalized && (!waitForDBKeyFlush || dbKeyFlushed);
}
}
Loading