HDDS-16378. Do not write upgrade.complete during upgrade-container-schema --dry-run - #11198
Open
shuan1026 wants to merge 1 commit into
Open
HDDS-16378. Do not write upgrade.complete during upgrade-container-schema --dry-run#11198shuan1026 wants to merge 1 commit into
shuan1026 wants to merge 1 commit into
Conversation
shuan1026
marked this pull request as ready for review
September 3, 2026 07:44
chihsuan
approved these changes
Sep 3, 2026
chihsuan
left a comment
chihsuan
left a comment
Contributor
There was a problem hiding this comment.
Thanks @shuan1026 +1 LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
--dry-runofozone repair datanode upgrade-container-schemastill wrote the permanentupgrade.completemarker. The real run then skipped every marked volume. Details are on the Jira.This patch:
upgrade.completeonly whene == null && r.isSuccess() && !isDryRun(). Dry-run still deletesupgrade.lock.lockFile(notfile) to the lock-delete error log in the samewhenComplete.TestUpgradeContainerSchema.testUpgradethat the marker is absent after dry-run and present after a real run.This does not delete markers already left by an older dry-run. Operators who already ran
--dry-runshould remove each volume'shddsRootDir/upgrade.completebefore the real upgrade.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-16378
How was this patch tested?
TestUpgradeContainerSchema(including the newupgrade.completeexistence checks on bothdryRunparameter values).