HDDS-15966. Fix flaky TestScmHAFinalization#testSnapshotFinalization

[errose28]

What changes were proposed in this pull request?

Failed here with a timeout at:

	at org.apache.ozone.test.GenericTestUtils.waitFor(GenericTestUtils.java:137)
	at org.apache.hadoop.hdds.upgrade.HddsUpgradeTestUtils.waitForScmToFinalize(HddsUpgradeTestUtils.java:125)
	at org.apache.hadoop.hdds.upgrade.HddsUpgradeTestUtils.waitForScmsToFinalize(HddsUpgradeTestUtils.java:119)
	at org.apache.hadoop.hdds.upgrade.TestScmHAFinalization.testSnapshotFinalization(TestScmHAFinalization.java:173)
	at java.base/java.lang.reflect.Method.invoke(Method.java:565)
	at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:511)
	at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1450)
	at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:2019)
	at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:187)

Logs show that it timed out waiting for scm2 to exit safemode. Safemode exit is this is no longer required for SCM finalization in the new upgrade framework, it is only required to instruct OMs to finalize which is not covered by this test. We can remove the safemode check from the wait.

What is the link to the Apache JIRA

HDDS-15966

How was this patch tested?

100 runs on my fork: https://github.com/errose28/ozone/actions/runs/30111725666/job/89543515225
This run was built off #10678 in case the failure was caused by the PR's changes. The test passed with a fix independent of the PR though.

[ayushtkn]

Thanx @errose28

it is only required to instruct OMs to finalize which is not covered by this test.

We are changing the common util here, so if there is case where it is required. Do you think we should rather not do this?

Logs show that it timed out waiting for scm2 to exit safemode.

btw why scm2 wasn't coming out Safemode?

[dombizita]

We are changing the common util here, so if there is case where it is required. Do you think we should rather not do this?

This PR is open to the HDDS-14496-zdu branch, where I think there won't be any case where it's required.

[github-actions]

This PR has been marked as stale due to 21 days of inactivity. Please comment or remove the stale label to keep it open. Otherwise, it will be automatically closed in 7 days.

[github-actions]

Thank you for your contribution. This PR is being closed due to inactivity. Please contact a maintainer if you would like to reopen it.

[errose28]

Two fixes and a full root cause are present in #11200