HDDS-15887. SCM should update DatanodeDetails ports on DN re-registration or heartbeat when only ports change#10784
Open
amaliujia wants to merge 1 commit into
Open
HDDS-15887. SCM should update DatanodeDetails ports on DN re-registration or heartbeat when only ports change#10784amaliujia wants to merge 1 commit into
amaliujia wants to merge 1 commit into
Conversation
…ration or heartbeat when only ports change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When a datanode re-registers with SCM or sends heartbeats after gaining new ports (e.g. RATIS_DATASTREAM when dfs.container.ratis.datastream.enabled is enabled), SCM does not update the stored DatanodeDetails in the node registry unless IP, hostname, or software version also changed. Port-only updates are ignored.
This JIRA propose to re-registration path (SCMNodeManager.register()) to update the port if there is any change detected.
This PR is assisted by Cursor.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-15887
(Please replace this section with the link to the Apache JIRA)
How was this patch tested?
Unit tests