HDDS-14922. Define invokeRatisServer or invokeRatisClient methods#10013
HDDS-14922. Define invokeRatisServer or invokeRatisClient methods#10013Russole wants to merge 4 commits intoapache:masterfrom
Conversation
|
Hi @szetszwo, could you please review this PR when you have time? Thank you! |
There was a problem hiding this comment.
@Russole , thanks for working on this! We should not use Proxy.newProxyInstance(..) anymore; see https://issues.apache.org/jira/secure/attachment/13081517/10013_review.patch
| if (invoker != null) { | ||
| return invoker.invokeRatisServer( | ||
| method.getName(), method.getParameterTypes(), args); | ||
| } |
There was a problem hiding this comment.
This change does not help since it is after the proxy. We should do it before the proxy.
|
Thanks @szetszwo for the review. Updated the implementation to handle overloaded |
What changes were proposed in this pull request?
invokeRatisServer(..)toScmInvokerto centralize Ratis server invocation logicSCMHAInvocationHandlertoScmInvokerSCMHAInvocationHandlerto delegateDIRECTinvocation toScmInvokerScmInvokeris not available (for backward compatibility)DeletedBlockLogStateManagerFollow-up
DeletedBlockLogStateManagerfirst; other SCM handlers will be updated in follow-up patchesWhat is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-14922
How was this patch tested?