HDDS-13446. Replace goofys with mountpoint-s3 in ozone-docker-runner#50
Merged
adoroszlai merged 4 commits intoapache:masterfrom Jul 18, 2025
Merged
HDDS-13446. Replace goofys with mountpoint-s3 in ozone-docker-runner#50adoroszlai merged 4 commits intoapache:masterfrom
adoroszlai merged 4 commits intoapache:masterfrom
Conversation
jojochuang
reviewed
Jul 17, 2025
Contributor
jojochuang
left a comment
There was a problem hiding this comment.
Looks good. But I would like to wait until the Ozone CSI is ready to migrate to goofys. Otherwise acceptance tests will fail.
jojochuang
reviewed
Jul 17, 2025
Dockerfile
Outdated
Comment on lines
48
to
57
| RUN set -eux ; \ | ||
| ARCH="$(arch)"; \ | ||
| case "${ARCH}" in \ | ||
| x86_64) arch='x86_64' ;; \ | ||
| aarch64) arch='arm64' ;; \ | ||
| *) echo "Unsupported architecture: ${ARCH}"; exit 1 ;; \ | ||
| esac; \ | ||
| curl -L -o /tmp/mount-s3.rpm "https://s3.amazonaws.com/mountpoint-s3-release/latest/${arch}/mount-s3.rpm"; \ | ||
| dnf install -y /tmp/mount-s3.rpm; \ | ||
| rm -f /tmp/mount-s3.rpm |
Contributor
There was a problem hiding this comment.
Suggest to use a fixed version instead of the latest version:
Suggested change
| RUN set -eux ; \ | |
| ARCH="$(arch)"; \ | |
| case "${ARCH}" in \ | |
| x86_64) arch='x86_64' ;; \ | |
| aarch64) arch='arm64' ;; \ | |
| *) echo "Unsupported architecture: ${ARCH}"; exit 1 ;; \ | |
| esac; \ | |
| curl -L -o /tmp/mount-s3.rpm "https://s3.amazonaws.com/mountpoint-s3-release/latest/${arch}/mount-s3.rpm"; \ | |
| dnf install -y /tmp/mount-s3.rpm; \ | |
| rm -f /tmp/mount-s3.rpm | |
| RUN set -eux ; \ | |
| ARCH="$(arch)"; \ | |
| MOUNTPOINT_S3_VERSION="1.19.0"; \ | |
| case "${ARCH}" in \ | |
| x86_64) url="https://s3.amazonaws.com/mountpoint-s3-release/${MOUNTPOINT_S3_VERSION}/x86_64/mount-s3-${MOUNTPOINT_S3_VERSION}-x86_64.rpm" ;; \ | |
| aarch64) url="https://s3.amazonaws.com/mountpoint-s3-release/${MOUNTPOINT_S3_VERSION}/arm64/mount-s3-${MOUNTPOINT_S3_VERSION}-arm64.rpm" ;; \ | |
| *) echo "Unsupported architecture: ${ARCH}"; exit 1 ;; \ | |
| esac; \ | |
| curl -L ${url} -o mount-s3.rpm ; \ | |
| dnf install -y mount-s3.rpm ; \ | |
| rm -f mount-s3.rpm |
Contributor
Author
There was a problem hiding this comment.
Thanks @jojochuang , it's a better solution.
I will modify it ASAP.
jojochuang
approved these changes
Jul 17, 2025
adoroszlai
reviewed
Jul 18, 2025
Dockerfile
Outdated
Comment on lines
52
to
56
| x86_64) url="https://s3.amazonaws.com/mountpoint-s3-release/${MOUNTPOINT_S3_VERSION}/x86_64/mount-s3-${MOUNTPOINT_S3_VERSION}-x86_64.rpm" ;; \ | ||
| aarch64) url="https://s3.amazonaws.com/mountpoint-s3-release/${MOUNTPOINT_S3_VERSION}/arm64/mount-s3-${MOUNTPOINT_S3_VERSION}-arm64.rpm" ;; \ | ||
| *) echo "Unsupported architecture: ${ARCH}"; exit 1 ;; \ | ||
| esac; \ | ||
| curl -L ${url} -o mount-s3.rpm ; \ |
Contributor
There was a problem hiding this comment.
nit: please reduce duplication
Suggested change
| x86_64) url="https://s3.amazonaws.com/mountpoint-s3-release/${MOUNTPOINT_S3_VERSION}/x86_64/mount-s3-${MOUNTPOINT_S3_VERSION}-x86_64.rpm" ;; \ | |
| aarch64) url="https://s3.amazonaws.com/mountpoint-s3-release/${MOUNTPOINT_S3_VERSION}/arm64/mount-s3-${MOUNTPOINT_S3_VERSION}-arm64.rpm" ;; \ | |
| *) echo "Unsupported architecture: ${ARCH}"; exit 1 ;; \ | |
| esac; \ | |
| curl -L ${url} -o mount-s3.rpm ; \ | |
| x86_64) arch='x86_64' ;; \ | |
| aarch64) arch='arm64' ;; \ | |
| *) echo "Unsupported architecture: ${ARCH}"; exit 1 ;; \ | |
| esac; \ | |
| curl -L "https://s3.amazonaws.com/mountpoint-s3-release/${MOUNTPOINT_S3_VERSION}/${arch}/mount-s3-${MOUNTPOINT_S3_VERSION}-${arch}.rpm" -o mount-s3.rpm ; \ |
Contributor
Author
There was a problem hiding this comment.
Thanks @adoroszlai for reviewing the duplication issue.
adoroszlai
approved these changes
Jul 18, 2025
Contributor
|
Thanks @echonesis for the patch, @jojochuang for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Apache Ozone presently utilizes
goofysas its S3 FUSE implementation. Given that thegoofysrepository has been forked and is now under the maintenance of StatCan, our intention is to transition tomountpoint-s3, an AWS Labs-maintained package, for subsequent development efforts.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-13446
How was this patch tested?
CI: https://github.com/echonesis/ozone-docker-runner/actions/runs/16337455101