Skip to content

Conversation

@Pilot-Pirx
Copy link
Member

X11 cursors are the only that use "nodrop" instead of "notallow" cursor.

X11 cursors are the only that use "nodrop" instead of "notallow" cursor.
@Pilot-Pirx Pilot-Pirx marked this pull request as draft December 20, 2025 10:41
@Pilot-Pirx Pilot-Pirx requested a review from ardovm December 20, 2025 14:56
@Pilot-Pirx
Copy link
Member Author

Pilot-Pirx commented Dec 20, 2025

@ardovm
Copy link
Contributor

ardovm commented Dec 22, 2025

Could you please elaborate a bit about this PR? How can we display the cursors you are working on?

@Pilot-Pirx
Copy link
Member Author

I can display and open them with GIMP by renaming from .h to .xbm.

The 4 cursors are identical to those in:
https://github.com/apache/openoffice/tree/trunk/main/vcl/inc/unx/x11_cursors

@ardovm
Copy link
Contributor

ardovm commented Dec 22, 2025

Thanks, where are these cursors used in the OpenOffice interface?

@Pilot-Pirx
Copy link
Member Author

They are for Drag and Drop operations.
I usually test them in Writer by dragging content in a table from one cell to another.

@ardovm
Copy link
Contributor

ardovm commented Dec 23, 2025

@ardovm Can we get rid of the redundant X11 cursors in https://github.com/apache/openoffice/tree/trunk/main/vcl/unx/generic/dtrans ?

Maybe we can add a path to "unx/x11_cursors" here? https://github.com/apache/openoffice/blob/trunk/main/vcl/unx/generic/dtrans/X11_selection.cxx#L54

I tried exactly that, and it seems to work!

@Pilot-Pirx Pilot-Pirx marked this pull request as ready for review December 23, 2025 20:29
@Pilot-Pirx Pilot-Pirx merged commit 2fb96a1 into trunk Dec 23, 2025
1 check passed
@Pilot-Pirx Pilot-Pirx deleted the Pilot-Pirx-nodrop branch December 23, 2025 21:51
asf-gitbox-commits pushed a commit that referenced this pull request Dec 23, 2025
* Replace nodrop -> notallow to unify cursor themes

X11 cursors are the only that use "nodrop" instead of "notallow" cursor.

* Additional files

* Get rid of duplicated cursors

(cherry picked from commit 2fb96a1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants