Skip to content

Conversation

@Pilot-Pirx
Copy link
Member

@Pilot-Pirx Pilot-Pirx commented Dec 10, 2025

At least for Windows we could use 32-bit color-depth cursors (incl. transparency), which are supported since Windows XP.
That should be possible for macOS (PNG), too?
I am sure that we could use PNG files for creation of the X11 cursors, too? But that may need some code changes...

@Pilot-Pirx Pilot-Pirx marked this pull request as draft December 10, 2025 16:24
@Pilot-Pirx Pilot-Pirx changed the title New design for table selection New design for table selection cursors Dec 10, 2025
@Pilot-Pirx Pilot-Pirx requested a review from ardovm December 16, 2025 14:06
@Pilot-Pirx
Copy link
Member Author

@ardovm Could you try to build with the X11 cursor?
It is done completely "by hand", the process is very error prone... ;-)

BTW: Do you have any idea how we could use more "modern" cursors for Linux?

@Pilot-Pirx Pilot-Pirx marked this pull request as ready for review December 16, 2025 20:05
@ardovm
Copy link
Contributor

ardovm commented Dec 17, 2025

cursor_down This is how the down pointing arrow appears... I am afraid this is not the outcome you expected?

@ardovm
Copy link
Contributor

ardovm commented Dec 17, 2025

cursor_right This is the right-pointing cursor

@Pilot-Pirx
Copy link
Member Author

Pilot-Pirx commented Dec 17, 2025

Those are the ones with 24x24. Maybe AOO does not like it and I need to do them 32x32?
How does the south-east look like (16x16)?

Nope, I switched the bits... ;-)

@Pilot-Pirx Pilot-Pirx marked this pull request as draft December 17, 2025 22:03
@Pilot-Pirx
Copy link
Member Author

These X11 cursors are basically XBM files (monochrome cursor). Maybe we could switch to XPM at some point?

@Pilot-Pirx Pilot-Pirx marked this pull request as ready for review December 18, 2025 09:28
@ardovm
Copy link
Contributor

ardovm commented Dec 18, 2025

On Linux, your cursors appear as black triangles. The PNG's you uploaded for aqua seem to be white triangles instead... is this intended?

@Pilot-Pirx
Copy link
Member Author

Pilot-Pirx commented Dec 18, 2025

Yes, Linux (and OS/2) cursors are black.
However, the "mask" appears as white.

Copy link
Contributor

@ardovm ardovm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me on Linux.
I suggest squashing the commits into a single one.

@Pilot-Pirx Pilot-Pirx merged commit 3cf928b into trunk Dec 18, 2025
1 check passed
@Pilot-Pirx Pilot-Pirx deleted the Pilot-Pirx-table branch December 18, 2025 22:11
asf-gitbox-commits pushed a commit that referenced this pull request Dec 18, 2025
* New design for table selection

* New cursors

* Smoother Windows cursors

* Smoother macOS cursors

* Updated X11 cursor

* Next updated X11 cursor

* Next updated X11 cursor

* Last updated X11 cursor

* Corrected X11 cursor

* Hopefully corrected X11 cursor

* Hopefully corrected X11 cursors

* Corrected X11 cursors

(cherry picked from commit 3cf928b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants