Conversation
Stack the preserved neural implementation and its tests on the reviewed classical component. Reuse the shared sample input validation and retain the classical review fixes. The standard model format, training parameters, scoring deduplication and cache ownership review work remain for this ticket. Validation: 253 focused tests passed; evaluation sources compiled and the HTML manual built. Neural evaluation fixtures are preserved but were not rerun during this history-only extraction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the feedforward neural dependency parser split from #1236, with greedy and beam decoding, training, and regression tests. This draft is stacked on #1236 and targets its branch so the diff contains only OPENNLP-1991.
Remaining work: standard model/training and factory/CLI integration, shared scoring code, parser-owned caches, deterministic vocabulary ordering, and fresh neural evaluations. All 253 selected tests pass; evaluation sources and the HTML manual build. Neural evaluations have not been rerun for this split.