feat(core): return metadata from read#7624
Draft
Xuanwo wants to merge 18 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #5872.
Rationale for this change
Read responses already carry useful metadata such as payload length, content range, ETag, and last modified time. Returning this metadata from
RpReadlets upper layers observe read metadata without forcing an extra stat on the hot read path.What changes are included in this PR?
This updates
RpReadto carryMetadatainstead of separate size/range hints, exposes observed metadata from readers and read streams, and wires existing services to populate read metadata from response headers, in-memory buffers, fs metadata, or existing service-specific read information.Are there any user-facing changes?
Yes.
Reader::metadata()can return complete object metadata observed after reads, and stream adapters can expose read response metadata before consuming the response body.RpRead::sizeandRpRead::rangeare replaced byRpRead::metadata.AI Usage Statement
Used OpenAI GPT-5 to assist implementation.