feat(core): implement debug for readers and writers#7616
Open
officialasishkumar wants to merge 1 commit into
Open
feat(core): implement debug for readers and writers#7616officialasishkumar wants to merge 1 commit into
officialasishkumar wants to merge 1 commit into
Conversation
Add Debug implementations for Reader, Writer, and their futures adapters using existing operation context such as scheme, root, path, args, and options. Add focused tests for debug output and update trait assertions to cover the new Debug bounds.
dosubot
Bot
added
size:L
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #6076.
Rationale for this change
ReaderandWriterare useful to store inside downstream types that requireDebug, and their current lack of debug output also makes operation context harder to inspect.What changes are included in this PR?
DebugforReaderandWriterusing existing operation context.DebugforFuturesAsyncReaderandFuturesAsyncWriter.Debugbounds.Are there any user-facing changes?
Reader,Writer,FuturesAsyncReader, andFuturesAsyncWriternow implementDebug.AI Usage Statement
Not applicable.