feat(core): add write expires support#7615
Open
officialasishkumar wants to merge 2 commits into
Open
Conversation
Add a write_with_expires capability and plumb per-write expiration through WriteOptions and OpWrite. Implement per-write expiration for Redis and Memcached, and cover unsupported capability checks plus behavior tests for expiring writes.
dosubot
Bot
added
size:L
officialasishkumar
requested review from
Zheaoli,
messense,
suyanhanx and
tisonkun
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #5623.
Rationale for this change
Cache-oriented services can apply default TTLs today, but callers cannot choose an expiration for an individual write. Exposing this through write options lets callers set a per-object lifetime when the backend supports native expiry.
What changes are included in this PR?
write_with_expirescapability andWriteOptions::expiresplumbing throughOpWrite..expires(Duration)builders for write and writer futures.Are there any user-facing changes?
Users can call
write_with(...).expires(Duration)andwriter_with(...).expires(Duration)on services that reportwrite_with_expires.AI Usage Statement
Not applicable.