Add regression CI test for aws-lc-rs#7583
Draft
valkum wants to merge 2 commits into
Draft
Conversation
Adds a new opt-in Cargo feature `reqwest-rustls-no-provider-tls` that maps to `reqwest/rustls-no-provider`. This lets downstream users enable rustls without forcing `aws-lc-rs` as the crypto provider, so they can install their own (e.g. `ring`). The existing `reqwest-rustls-tls` feature and the default feature set are unchanged, so this is purely additive. Part of: apache#7571
The new feature exists specifically to keep `aws-lc-rs` out of the rustls crypto-provider slot so downstream crates can install their own provider (`ring`, etc.). That guarantee is a property of the dependency tree, not the source, so it can silently regress as transitive deps shift. Adds a job to `ci_core.yml` that runs `cargo tree` against `opendal` with the `services-gcs` and `reqwest-rustls-no-provider-tls` enabled and asserts no `aws-lc-rs` node. `--edges normal,build` mirrors what `cargo build` actually compiles (library deps + build scripts) and excludes workspace-only dev-deps that would otherwise trip false alarms.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #7571.
Rationale for this change
Avoids future regressions that bring back
aws-lc-rsaccidentally.What changes are included in this PR?
This PR is stacked on #7582 as it currently fails due to
reqsign-google.A CI step that checks for
aws-lc-rsincargo treefor specific features.This step should probably run with all services that have no hard requirement on
aws-lc-rs. I choseservices-gcsbecause I knew it currently fails due toreqsign-google.Are there any user-facing changes?
No
AI Usage Statement
Used claude code Opus 4.7 to review my changes before filing the PR.