fix(dav-server): abort writer on write failure#7569
Open
andrei-21 wants to merge 1 commit into
Open
Conversation
dosubot
Bot
added
size:M
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #7425.
Rationale for this change
OpenDAL writers must be explicitly finalized with either
close()orabort(). The dav-server integration previously adaptedWriterintoFuturesAsyncWriter, which only exposedAsyncWriteoperations and did not allowabort()to be called when a write path failed beforeclose().What changes are included in this PR?
Keep the OpenDAL Writer in
OpendalFileso failed write and close paths can abort the writer before returning an error. This prevents failed PUT operations from leaving the writer to be dropped without explicit termination.Are there any user-facing changes?
No.
AI Usage Statement
Codex with gpt-5.5 model was used.