This repository was archived by the owner on Dec 30, 2018. It is now read-only.
Prevent a full class-path scanning each time Cell#setTextContent is called #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svanteschubert
approved these changes
Oct 6, 2017
Contributor
svanteschubert
left a comment
svanteschubert
left a comment
There was a problem hiding this comment.
Thanks, I have pushed the fix according ODFTOOLKIT-424.
Please note that we are switching now to GIT from SVN and currently the GitHub Repo is still read-only.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That's a serious performance issue. Every-time the content of a cell is set, the whole classpath is scanned to find always the same implementation of some XML factories...
fixes https://issues.apache.org/jira/browse/ODFTOOLKIT-424