Repository navigation
Conversation
Use lower-bound lookup for non-linear pool size classes so exact-size requests are served by the matching pool instead of the next larger one. Signed-off-by: chao an <anchao.archer@bytedance.com>
xiaoxiang781216
approved these changes
Oct 27, 2026
|
casaroli
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the pool selection logic in multiple mempool lookup for non-linear pool
size classes.
For multiple mempools without a fixed arithmetic size delta, the lookup uses a
binary search to find the first pool that can satisfy the requested allocation
size. The previous comparison only accepted pools whose block size was strictly
greater than the requested size, so an exact-size request skipped the matching
pool and selected the next larger pool instead.
This changes the binary search condition from
>to>=, making it a properlower-bound lookup. Exact-size requests are now served by the matching pool.
Impact
This fixes allocation behavior for multiple mempools using non-linear block
sizes.
Expected impact:
Testing
sim/nsh