[5.75/10] libs/libc/machine/arm: Fix the nxstyle errors in arch_elf.c. - #20026
Open
casaroli wants to merge 1 commit into
Open
[5.75/10] libs/libc/machine/arm: Fix the nxstyle errors in arch_elf.c.#20026casaroli wants to merge 1 commit into
casaroli wants to merge 1 commit into
Conversation
Both files put the body of the relocation switch at the same indent as the switch braces, so nxstyle reports forty-four errors in each and any patch whose hunks land near them fails the check job. Giving the body its level takes the bit diagrams in the comments one column past the line limit. The rulers say Instr rather than Instructions, which is enough and is what the same rulers further down already do. A comment that had no code on its line becomes a sentence of its own, and two that were a column out are put right. Whitespace and comments only. Compiled before and after for cortex-m7 and cortex-m33: the disassembly is identical. Signed-off-by: Marco Casaroli <marco.casaroli@gmail.com>
github-actions
Bot
added
Area: OS Components
casaroli
marked this pull request as ready for review
August 31, 2026 20:27
acassis
approved these changes
Aug 31, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part 5.75 of the split of #19673, and only formatting.
libs/libc/machine/arm/armv7-m/arch_elf.cand its armv8-m twin put the body of the relocation switch at the same indent as the switch braces. nxstyle reports forty-four errors in each:CI feeds nxstyle the diff hunks with three lines of context, so any patch whose hunks land near them fails the check job through no fault of its own.
[6/10]adds theR_ARM_FUNCDESCcases to those switches, so its hunks land throughout. This clears the way rather than making that PR carry the reformat.Giving the switch body its level takes the bit diagrams in the comments one column past the line limit. Three things follow from that:
Instrrather thanInstructions, which is enough and is what the same rulers further down the file already doImpact
None. Whitespace and comments.
Testing
Both files are clean afterwards:
Compiled each file before and after, for cortex-m7 and cortex-m33, and compared the disassembly:
mps3-an547:picostestbuilds.tools/checkpatch.sh -c -u -m -gpasses.