boards/arm/stm32{f1,f4}: drop duplicated reset.c/romfs#19431
Merged
jerpelea merged 1 commit intoJul 14, 2026
Conversation
…ard logic The board-common stm32_reset.c and stm32_romfs_initialize.c are already provided by boards/arm/common/stm32. Remove the redundant local copies from boards Signed-off-by: raiden00pl <raiden00@railab.me>
raiden00pl
requested review from
Donny9,
GUIDINGLI,
acassis,
gustavonihei,
jerpelea,
masayuki2009,
michallenc,
patacongo,
pkarashchenko,
rcsim,
tmedicci and
xiaoxiang781216
as code owners
github-actions
Bot
added
Size: M
|
xiaoxiang781216
approved these changes
Jul 14, 2026
jerpelea
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The board-common stm32_reset.c and stm32_romfs_initialize.c are already provided by boards/arm/common/stm32. Remove the redundant local copies from boards
Impact
remove duplicated code
Testing
stm32f4disco, ROMFS and reboot command works: