sim/posix: Add APPLE to a build target for sim's configuration using CMake.#18883
sim/posix: Add APPLE to a build target for sim's configuration using CMake.#18883toku-mac wants to merge 2 commits into
Conversation
|
@no1wudi Could you help to review the PR thanks :-) |
|
@toku-mac Could you check CMakeLists.txt thanks :-) |
|
Sorry, I fixed in commit 118d09c. |
|
@toku-mac Remember to add "Signed-off-by" thanks :-) |
…CMake. * Adjust macOS coverage linker configuration settings. * Resolve linker errors caused by the absence of `-lgcov`. * Fix an issue where `macho_call_saved_init_funcs()` on macOS could improperly reference `g_saved_init_funcs`. * Eliminate the Rust/Tokio `clock_gettime()` panic that occurred when running `hello_rust_cargo` on the NuttX sim on macOS. * Add support for treating Darwin's `CLOCK_MONOTONIC=6` and `CLOCK_UPTIME_RAW=8` as NuttX's monotonic clock in `sched/clock/clock_gettime.c` (limited to sim/macOS environments). Signed-off-by: Shoji Tokunaga <toku@mac.com>
118d09c to
e14a952
Compare
|
I squashed at commit e14a952 :-) |
It appears the process is stuck at this point. Could you please review the details? |
|
@simbit18 Any idea what's wrong with the Windows build? I restarted but it didn't help thanks! |
|
Hi @lupyuen , Repository not found it's the same URL that we use to build the Nuttx docker image nuttx/tools/ci/docker/linux/Dockerfile Line 53 in 8302295 https://nuttx.apache.org/docs/latest/quickstart/install.html#kconfig-frontend Maybe the kconfig-frontends sources need to be moved to the https://github.com/orgs/NuttX/repositories |
|
Hi @patacongo, we can no longer access the repository https://bitbucket.org/nuttx/tools.git. Could you please have a look? |
|
Sorry, I made a mistake with git operations at apps PR. |
|
I am having trouble with Bitbucket authentication so I moved the tools/ repository to https://github.com/patacongo/tools
|
…CMake. * Adjust macOS coverage linker configuration settings. * Resolve linker errors caused by the absence of `-lgcov`. * Fix an issue where `macho_call_saved_init_funcs()` on macOS could improperly reference `g_saved_init_funcs`. * Eliminate the Rust/Tokio `clock_gettime()` panic that occurred when running `hello_rust_cargo` on the NuttX sim on macOS. * Add support for treating Darwin's `CLOCK_MONOTONIC=6` and `CLOCK_UPTIME_RAW=8` as NuttX's monotonic clock (limited to sim/macOS environments). Signed-off-by: Shoji Tokunaga <toku@mac.com>
Summary
hello_rust_cargoCMake build configuration.gcc, its actual implementation isclang.Provides: apache/nuttx-apps#3483.
About
macho_call_saved_init_funcs()Issuesave_and_replace_init_funcs()does not appear at the head of__mod_init_func. For example, consider this sequence:__mod_init_funcentries in the order they appear,constructor Ahas already executed beforesave_and_replace_init_funcs()is called.elsebranch until it findssave_and_replace_init_funcs(), where it executesg_saved_init_funcs[i - 1] = *fp;.i == 0, soi - 1becomes out-of-bounds when interpreted without sign, or-1even as anint, resulting in an invalid write tog_saved_init_funcs[-1].macho_call_saved_init_funcs()side.Impact
Testing
I confirm that changes are verified on local setup and works as intended:
See the apps PR #3482 .
PR verification Self-Check