boards/xtensa: fix optional item on spiflash config#18559
Open
fdcavalcanti wants to merge 1 commit intoapache:masterfrom
Open
boards/xtensa: fix optional item on spiflash config#18559fdcavalcanti wants to merge 1 commit intoapache:masterfrom
fdcavalcanti wants to merge 1 commit intoapache:masterfrom
Conversation
github-actions
bot
added
Size: XS
Removes optional keyword causing selection to fail on the automatic bringup of SPI flash device. Signed-off-by: Filipe Cavalcanti <filipe.cavalcanti@espressif.com>
fdcavalcanti
force-pushed
the
bugfix/esp32s2-spiflash-option
branch
from
797a87e to
7a18246
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes optional keyword causing selection to fail on the
automatic bringup of SPI flash device.
I did a wrongful assessment of the test output on #18551. Sorry about that.
This new PR fixes the issue.
Impact
Impact on user: No.
Impact on build: No.
Impact on hardware: Only affects Espressif RISC-V and Xtensa devices.
Impact on documentation: No.
Impact on security: No.
Impact on compatibility: No.
Testing
Building
Tested on internal CI and ran
refresh.shscript.Running
Tested on all SoCs with
ostestandspiflash.All builds succeed and tests passing.