Skip to content

ntfc: drop the sim double-newline workaround #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xiaoxiang781216 merged 1 commit into from
Sep 1, 2026
+2 −6
Merged

ntfc: drop the sim double-newline workaround #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/ntfc/device/sim.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,6 @@
class DeviceSim(DeviceHost):
"""This class implements host-based sim emulator."""

# sometimes sim misses a single trailing newline, so send two
NEWLINE_PAD = b"\n\n"

def __init__(self, conf: "CoreConfig"):
"""Initialize sim emulator device."""
DeviceHost.__init__(self, conf)
Expand Down
5 changes: 2 additions & 3 deletions tests/device/test_sim.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,7 @@ def send(self, data):
sim._child = FakeChild()

sim._write(b"abc")
assert sent[:3] == [b"a", b"b", b"c"]
assert sent[-2:] == [b"\n", b"\n"]
assert sent == [b"a", b"b", b"c", b"\n"]


def test_device_sim_write_no_extra_newline():
Expand Down Expand Up @@ -134,7 +133,7 @@ def send(self, data):
sim._child = FakeChild()

sim._write(b"abc")
assert sent == [b"abc\n\n"]
assert sent == [b"abc\n"]

sent.clear()
sim._write(b"abc\n")
Expand Down