NIFI-16195 Wrote part headers into attributes - #11631
Open
dan-s1 wants to merge 1 commit into
Open
Conversation
pvillard31
requested changes
Sep 5, 2026
| runner.assertTransferCount(ExtractEmailAttachments.REL_ATTACHMENTS, 0); | ||
| } | ||
|
|
||
| private void assertAttachmentHeaderAttributes(MockFlowFile split) { |
Contributor
There was a problem hiding this comment.
Can the tests assert the exact header attribute names and values, and cover body, inline image, and attachment parts to verify the behavior described in NIFI-16195?
| } | ||
|
|
||
| for (Map.Entry<String, String> entry : attachment.headers().entrySet()) { | ||
| final String headerAttributeName = ATTACHMENT_HEADER_ATTRIBUTE_PREFIX + entry.getKey(); |
Contributor
There was a problem hiding this comment.
Should the header name be lowercased when building the attribute name, as ExtractEmailHeaders does, so downstream flows can rely on stable attribute names?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-16195
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000VerifiedstatusPull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
./mvnw clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation