Skip to content

NIFI-16287 - Ensure orderly shutdown of active and idle JMS workers - #11619

Open
pvillard31 wants to merge 2 commits into
apache:mainfrom
pvillard31:NIFI-16287
Open

NIFI-16287 - Ensure orderly shutdown of active and idle JMS workers#11619
pvillard31 wants to merge 2 commits into
apache:mainfrom
pvillard31:NIFI-16287

Conversation

@pvillard31

Copy link
Copy Markdown
Contributor

Summary

NIFI-16287 - Ensure orderly shutdown of active and idle JMS workers

This change introduces explicit lifecycle ownership for every JMS worker created by AbstractJMSProcessor, including workers currently executing onTrigger. When a processor is unscheduled or loses primary-node ownership, active and idle workers are now closed promptly. Retired workers cannot be returned to the pool or rebuilt, and worker shutdown is idempotent so concurrent lifecycle and trigger threads cannot destroy the same connection factory more than once.

The accompanying tests exercise construction and shutdown races, primary-node transitions, and bulk cleanup failures. Broker-backed tests also verify that shutdown interrupts a blocked ConsumeJMS receive, preserves redelivery when acknowledgement occurs after closure, and maintains the existing PublishJMS success and failure routing behavior during concurrent shutdown.

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000
  • Pull request contains commits signed with a registered key indicating Verified status

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using ./mvnw clean install -P contrib-check
    • JDK 21
    • JDK 25

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant