Skip to content

NIFI-16122 Removed redundant type casts and implemented the use of the PMD rule UnnecessaryCast.#11440

Merged
exceptionfactory merged 1 commit into
apache:mainfrom
dan-s1:NIFI-16122
Jul 20, 2026
Merged

NIFI-16122 Removed redundant type casts and implemented the use of the PMD rule UnnecessaryCast.#11440
exceptionfactory merged 1 commit into
apache:mainfrom
dan-s1:NIFI-16122

Conversation

@dan-s1

@dan-s1 dan-s1 commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Summary

NIFI-16122

This PR aims to remove unnecessary casts throughout the code base. For example:

  • Casts in places where Java already performs Automatic Type Promotion (or Numeric Promotion).
  • Casts to the same type as the variable already was.
  • Cast for a method argument where the compiler could already disambiguate the method signature.

Casts that were untouched were:

  • Big-Endian byte-to-long conversion where some of the casts are actually needed so the ones not needed were kept for consistency.
  • Creating an unsigned 32-bit where the cast was necessary

In these cases the @SuppressWarnings("PMD.UnnecessaryCast") annotation on the method level was added to ignore the use of the cast.

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000
  • Pull request contains commits signed with a registered key indicating Verified status

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using ./mvnw clean install -P contrib-check
    • JDK 21
    • JDK 25

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

@exceptionfactory exceptionfactory left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dan-s1, the cleanup and additional PMD rule look good. +1 merging

@exceptionfactory
exceptionfactory merged commit 3946f72 into apache:main Jul 20, 2026
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants