NIFI-15987: Updating the global and connector specific policy managem…#11304
Open
mcgilman wants to merge 1 commit into
Open
NIFI-15987: Updating the global and connector specific policy managem…#11304mcgilman wants to merge 1 commit into
mcgilman wants to merge 1 commit into
Conversation
…ent pages to include policies for view/write data and viewing provenance events.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ent pages to include policies for view/write data and viewing provenance events.
Summary
Extends NiFi UI access policy management for connectors at global and per-instance scope, aligning with backend authorizable paths for connector data and provenance.
Global policies (
/access-policies):/data/connectors), view provenance (/provenance-data/connectors)Per-instance policies (component access policies):
connectorsbranch: data and provenance actions enabled; site-to-site disabledComponentType.Connectorcontext with inherited templates for/connectors,/data/connectors, and/provenance-data/connectorsAPI resource path fix (
AccessPolicyService):{ resource: 'connectors', resourceIdentifier: 'data' }maps to/data/connectors(not/connectors/data)provenance-data→/provenance-data/connectorsbuildResourcePath()centralizes path construction for create/get and policy status checksFound vs Inherited (
access-policy.effects.ts):component.resourcetobuildResourcePath()so connector data/provenance policies resolve correctly (including legacy wrong paths like/connectors/datashowing as Inherited)Users → Access Policies listing:
/data/connectorsand/provenance-data/connectorspoliciesShared UI:
ComponentContextandcomponent-type-namepipe support forComponentType.Connector(plug icon, “Connector” label)component-access-policiesselector corrected tocomponent-access-policiesQueue listing (bundled fix):
queueListingApiError, close dialogs, and stop polling so the progress dialog does not stay open indefinitelyTesting
nx test nifi— access policy service/effects specs, global/component access-policies specs, user-access-policies specs, component-context spec/connectors,/data/connectors,/provenance-data/connectors/connectors/data) show Inherited until recreatedNotes for reviewers
Policy migration: Policies created before this path transform used incorrect resources (e.g.
/connectors/data). The UI does not migrate them; delete and recreate at the correct paths if needed.Connector canvas provenance preview: Preview on the connector canvas is gated by global “query provenance” (
/provenance/currentUser.provenancePermissions.canRead), not by/provenance-data/connectors. Granting only connector provenance policies does not enable the preview control.Queue listing change: Included in this PR because it was discovered during connector policy QA; behavior is unrelated to access policies but fixes a stuck-dialog regression.