NIFI-15960 Replaced current property in AvroSchemaRegistry with a new one which utilizes a validation strategy where it details what Avro validations occur when choosing strict validation of Avro schemas.#11290
Open
dan-s1 wants to merge 5 commits into
Conversation
pvillard31
requested changes
Jun 1, 2026
| } | ||
| } | ||
|
|
||
| config.removeProperty(obsoletePropertyName); |
Contributor
There was a problem hiding this comment.
Should removeProperty(obsoletePropertyName) be guarded by hasProperty(obsoletePropertyName) (or the loop broken after the first match), so that the migration result only reports the property that was actually present?
Contributor
Author
There was a problem hiding this comment.
Javadoc on remove is
Removes the property with the given name, if it exists. If the property does not exist, this is a no-op.
Why would it be necessary then to be guarded by hasProperty(obsoletePropertyName) (or the loop broken after the first match)?
Contributor
Author
There was a problem hiding this comment.
@pvillard31 Are you okay if this is left as is?
… one which utilizes a validation strategy where it details what Avro validations occur when choosing strict validation of Avro schemas.
…t what the Avro code actually does (i.e. validate or does not validate).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-15960
This PR primarily details the various validations which occur when strict validation is chosen for validating Avro schemas in the AvroSchemaRegistry. The unit tests were overhauled to use the NIFI testing framework and multiple unit tests were added especially to contrast the difference between strict and lenient validation of Avro schemas.
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000VerifiedstatusPull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
./mvnw clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation