NIFI-15801 Stop processors in synchronizeProcessors before updating#11111
Open
kevdoran wants to merge 2 commits intoapache:mainfrom
Open
NIFI-15801 Stop processors in synchronizeProcessors before updating#11111kevdoran wants to merge 2 commits intoapache:mainfrom
kevdoran wants to merge 2 commits intoapache:mainfrom
Conversation
pvillard31
reviewed
Apr 7, 2026
...c/main/java/org/apache/nifi/flow/synchronization/StandardVersionedComponentSynchronizer.java
Outdated
Show resolved
Hide resolved
synchronizeProcessors() calls updateProcessor() which requires the processor to be stopped (setAnnotationData throws IllegalStateException if isRunning). The NiFi REST path stops affected processors before calling synchronizeFlow, but the Connector applyUpdate path does not, exposing this gap. Stop processors via stopOrTerminate before updateProcessor, matching the single-processor synchronize(ProcessorNode, ...) path. Track stopped processors and restart them in a finally block, matching the pattern used in synchronizeProcessGroupSettings.
markap14
reviewed
Apr 13, 2026
...c/main/java/org/apache/nifi/flow/synchronization/StandardVersionedComponentSynchronizer.java
Outdated
Show resolved
Hide resolved
| stoppedProcessors.add(processor); | ||
| } | ||
| } catch (final TimeoutException | FlowSynchronizationException e) { | ||
| throw new ProcessorInstantiationException(processor.getIdentifier(), e); |
Contributor
There was a problem hiding this comment.
I don't think this is the right Exception - we are not attempting to instantiate a Processor here, so I'd not throw ProcessorInstantiatonException, probably FlowSynchronizationException
Contributor
Author
There was a problem hiding this comment.
Thanks. I updated this, and as it is a checked exception, I had to add it to the method signature and all callers. Let me know if you are good with this @markap14.
Contributor
|
Thanks @kevdoran i think all looks good to me now. I'm a +1, happy to merge on successful Github Actions completion. |
markap14
approved these changes
Apr 13, 2026
Contributor
Author
|
Thanks @markap14 - I see a couple system test failures, but nothing related to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-15801
synchronizeProcessors() calls updateProcessor() which requires the processor to be stopped (setAnnotationData throws IllegalStateException if isRunning). The NiFi REST path stops affected processors before calling synchronizeFlow, but the Connector applyUpdate path does not, exposing this gap.
Stop processors via stopOrTerminate before updateProcessor, matching the single-processor synchronize(ProcessorNode, ...) path. Track stopped processors and restart them in a finally block, matching the pattern used in synchronizeProcessGroupSettings.
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000VerifiedstatusPull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
./mvnw clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation