Skip to content

NIFI-15648 - Resolve SECRET property values before fetchAllowableValues and verify in working flow context#10937

Open
pvillard31 wants to merge 1 commit intoapache:NIFI-15258from
pvillard31:NIFI-15648
Open

NIFI-15648 - Resolve SECRET property values before fetchAllowableValues and verify in working flow context#10937
pvillard31 wants to merge 1 commit intoapache:NIFI-15258from
pvillard31:NIFI-15648

Conversation

@pvillard31
Copy link
Contributor

Summary

NIFI-15648 - Resolve SECRET property values before fetchAllowableValues and verify in working flow context

When a connector calls fetchAllowableValues, the working flow context's ConnectorConfigurationContext may return null for properties with PropertyType.SECRET. This occurs because at the time the working flow context is cloned and setProperties resolves secrets, the backing ParameterProvider may not yet be valid, causing ParameterProviderSecretsManager.getSecretProviders() to return an empty set. The secret resolution silently stores null, and there is no subsequent re-resolution.

This does not affect verifyConfigurationStep, which bypasses stored resolved values by accepting explicit propertyValueOverrides from the UI and creating a new context with StringLiteralValue entries.

The fix adds resolvePropertyValues() calls in StandardConnectorNode before delegating to the connector's fetchAllowableValues (both overloads) and verify methods. This re-resolves SecretReference entries against the SecretsManager at the point of need, when the ParameterProvider is expected to be valid. This mirrors the existing pattern in start(), which already calls resolvePropertyValues() on the active flow context before starting the connector.

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000
  • Pull request contains commits signed with a registered key indicating Verified status

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using ./mvnw clean install -P contrib-check
    • JDK 21
    • JDK 25

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

@pvillard31 pvillard31 added the NIP-11 NIP-11 adds support for Connectors label Feb 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NIP-11 NIP-11 adds support for Connectors

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant