NIFI-15645 - Fix AzureLogAnalyticsReportingTask wrongly reporting invalid state#10935
Open
pvillard31 wants to merge 3 commits intoapache:mainfrom
Open
NIFI-15645 - Fix AzureLogAnalyticsReportingTask wrongly reporting invalid state#10935pvillard31 wants to merge 3 commits intoapache:mainfrom
pvillard31 wants to merge 3 commits intoapache:mainfrom
Conversation
dan-s1
reviewed
Feb 25, 2026
Comment on lines
126
to
132
| try { | ||
| new URI(MessageFormat.format(input, "workspace-id")).toURL(); | ||
| return new ValidationResult.Builder().subject(subject).input(input).valid(true).build(); | ||
| } catch (final Exception e) { | ||
| return new ValidationResult.Builder().subject(subject).input(input).valid(false) | ||
| .explanation("'%s' is not a valid URL format: %s".formatted(input, e.getMessage())).build(); | ||
| } |
Contributor
There was a problem hiding this comment.
This can be written simpler without the try catch.
Suggested change
| try { | |
| new URI(MessageFormat.format(input, "workspace-id")).toURL(); | |
| return new ValidationResult.Builder().subject(subject).input(input).valid(true).build(); | |
| } catch (final Exception e) { | |
| return new ValidationResult.Builder().subject(subject).input(input).valid(false) | |
| .explanation("'%s' is not a valid URL format: %s".formatted(input, e.getMessage())).build(); | |
| } | |
| ValidationResult validationResult = StandardValidators.URL_VALIDATOR.validate(subject, MessageFormat.format(input, "workspace-id"), context); | |
| if (validationResult.isValid()) { | |
| return new ValidationResult.Builder().subject(subject).input(input).valid(true).build(); | |
| } else { | |
| return new ValidationResult.Builder().subject(subject).input(input).valid(false) | |
| .explanation("'%s' is not a valid URL format: %s".formatted(input, e.getMessage())).build(); | |
| } |
Contributor
Author
There was a problem hiding this comment.
You are right, this is much cleaner
Contributor
There was a problem hiding this comment.
@pvillard31 I made an update as I didn't realize before what you were testing and what you placed in the valid message.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-15645 - Fix AzureLogAnalyticsReportingTask wrongly reporting invalid state
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000VerifiedstatusPull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
./mvnw clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation