NIFI-15641 Add FinalParameters and FinalLocalVariable checkstyle rules#10932
Open
pvillard31 wants to merge 1 commit intoapache:mainfrom
Open
NIFI-15641 Add FinalParameters and FinalLocalVariable checkstyle rules#10932pvillard31 wants to merge 1 commit intoapache:mainfrom
pvillard31 wants to merge 1 commit intoapache:mainfrom
Conversation
Added FinalParameters and FinalLocalVariable checks to checkstyle configuration and fixed all violations across the codebase. Parameters and local variables that can be declared final are now declared final. For parameters that are reassigned, applied the *Arg pattern (rename parameter, introduce local variable) to satisfy the checkstyle rule without changing behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-15641 Add FinalParameters and FinalLocalVariable checkstyle rules
Added FinalParameters and FinalLocalVariable checks to checkstyle configuration and fixed all violations across the codebase. Parameters and local variables that can be declared final are now declared final. For parameters that are reassigned, applied the *Arg pattern (rename parameter, introduce local variable) to satisfy the checkstyle rule without changing behavior.
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000VerifiedstatusPull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
./mvnw clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation