Improve XMLUtil and usage#9488
Open
mbien wants to merge 3 commits into
Open
Conversation
mbien
added
ci:all-tests
Contributor
|
I noticed after looking through this, that it is marked draft, but the intention looks sane to me and I would expect that the changed code paths will still work ("creative" entity usage is not something I expect in a build script for example). Thanks! |
Setting it to true by default would break compatibility, the existing parse methods will set the parameter to false (effectively leaving it unset, see below). 'getDOMImplementation()' and 'normalize()' will set it to true now. note regarding FEATURE_SECURE_PROCESSING: It is a tri-state boolean and can be implicit true, explicit true and explicit false. JDK 11+ has it on implicit true by default. Implicit true and explicit true are not the same, explicit true enables additional limits and checks, e.g it will throw on external entity loading attempts. (unless the external entity feature was disabled by other means, in which case it would simply ignore external entities) That is also why passing false as parameter to the new methods will leave it at its default value instead of turning it completely off. (it remains at implicit true)
some dead code removal
mbien
added
the
ci:dev-build
Member
Author
|
added a commit and rebased, rest remained unchanged. |
matthiasblaesing
approved these changes
Jul 12, 2026
matthiasblaesing
left a comment
matthiasblaesing
left a comment
Contributor
There was a problem hiding this comment.
This make sense to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some cleanup around XML factories