Draft
Conversation
mbien
commented
Mar 10, 2026
| DC15DFF8F701B227EE523EEB7A17F77C10EAFE2F org.jdom:jdom2:2.0.6.1 | ||
| 5D9CE6ADD7B714B8095F0E3E396C5E9F8C5DCFEF org.apache.maven.shared:maven-dependency-tree:2.2 | ||
| F0EE4660E55FDD9BC7F181843E41301D9292312A org.apache.maven:apache-maven:3.9.12:bin@zip | ||
| 487713BBA197D8E735ACF13712604C33C408F4A7 https://release-test.apache.org/download/path/maven/3.9.14/binaries/apache-maven-3.9.14-bin.zip apache-maven-3.9.14-bin.zip |
mbien
commented
Mar 10, 2026
Comment on lines
+42
to
+55
| # TODO update when embedded maven updates | ||
|
|
||
| # Classpath for agent injected into maven run (sourcecode in mavensrc) | ||
| mavensrc.cp=:\ | ||
| ./external/aether-api-1.13.1.jar:\ | ||
| ${libs.json_simple.dir}/modules/ext/json-simple-1.1.1.jar:\ | ||
| ${maven.embedder.dir}/maven/boot/plexus-classworlds-2.9.0.jar:\ | ||
| ${maven.embedder.dir}/maven/lib/javax.annotation-api-1.3.2.jar:\ | ||
| ${maven.embedder.dir}/maven/lib/javax.inject-1.jar:\ | ||
| ${maven.embedder.dir}/maven/lib/maven-core-3.9.12.jar:\ | ||
| ${maven.embedder.dir}/maven/lib/maven-model-3.9.12.jar:\ | ||
| ${maven.embedder.dir}/maven/lib/maven-plugin-api-3.9.12.jar:\ | ||
| ${maven.embedder.dir}/maven/lib/maven-resolver-api-1.9.25.jar:\ | ||
| ${maven.embedder.dir}/maven/lib/org.eclipse.sisu.plexus-0.9.0.M4.jar:\ | ||
| ${maven.embedder.dir}/maven/lib/maven-core-3.9.14.jar:\ | ||
| ${maven.embedder.dir}/maven/lib/maven-model-3.9.14.jar:\ | ||
| ${maven.embedder.dir}/maven/lib/maven-plugin-api-3.9.14.jar:\ | ||
| ${maven.embedder.dir}/maven/lib/maven-resolver-api-1.9.27.jar:\ | ||
| ${maven.embedder.dir}/maven/lib/org.eclipse.sisu.plexus-1.0.0.jar:\ |
Member
Author
There was a problem hiding this comment.
maven updates have to adjust those paths too now, but build should fail without it so it can't be easily overlooked (#9120)
Contributor
There was a problem hiding this comment.
ok, and we need aether sonatype for backward compatibility but LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changes:
uses staged build until vote finishes
manually tested indexing, SMO, hello world build/run and some actions (all on JDK 26)