Open
Conversation
mbien
added
Code cleanup
Member
Author
|
i should probably drop the lib wrappers without sources to their wrapped bytecode level. |
Contributor
|
Looks sane to me. If I remember correctly the only drawback for wrappers is that the required java level might be to high, but I don't see that as a problem. Also not all wrappers are affected as at least come of them bundle the libraries by making them directly loaded modules. The bouncy castle libraries are included like this (see |
skipped - xml.tax - xml.text.obsolete90 - o.n.agent - dlight.nativeexecution consolidated compiler args property edited db.mysql sig file (Thread.destroy() and stop() removal) dropped libwrappers (without sources) to their bytecode level if they had a javac property defined.
Member
Author
|
wrote a script which found lib wrappers which had no sources but had the javac property set and dropped the value to their bytecode level. Most if not all properties could have likely been removed, but I didn't want to change too much. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
skipped
consolidated compiler args property
edited db.mysql sig file (Thread.destroy() and stop() removal)
dropped libwrappers (without sources) to their bytecode level if they had a javac property defined.
meta issue #8813