Add the "addScripts" configuration parameter #1281
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olamy
requested changes
Oct 28, 2025
Member
olamy
left a comment
olamy
left a comment
There was a problem hiding this comment.
Thanks for your contribution. I have added a couple of comments.
| # specific language governing permissions and limitations | ||
| # under the License. | ||
|
|
||
| invoker.goals=compile javadoc:javadoc |
Member
There was a problem hiding this comment.
if available only since jdk 18, you need add something such
invoker.java.version = 18+
| return; | ||
| } | ||
|
|
||
| for (String addScript : addScripts) { |
Member
There was a problem hiding this comment.
maybe check if the jdk is at least 18, if not throw a proper error message
Author
There was a problem hiding this comment.
hey 👋🏻 , thanks for having a look and for the suggestions!
I'll try to address these soon 🙂.
Author
There was a problem hiding this comment.
addArgIfNotEmpty( had that check to produce a warning, but as you've suggested... I added a check and exception just above ^.
thanks 🙂
to support the "--add-script" argument of the javadoc tool: https://docs.oracle.com/en/java/javase/18/docs/specs/man/javadoc.html
marko-bekhta
force-pushed
the
feat/add-add-script-option
branch
from
3d26e03 to
68c8835
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for the "--add-script" argument of the javadoc tool: https://docs.oracle.com/en/java/javase/18/docs/specs/man/javadoc.html
this one follows the approach taken for the additional stylesheets and adds the same functionality for the additional scripts.
Following this checklist to help us incorporate your
contribution quickly and easily:
Note that commits might be squashed by a maintainer on merge.
This may not always be possible but is a best-practice.
mvn verifyto make sure basic checks pass.A more thorough check will be performed on your pull request automatically.
mvn -Prun-its verify).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.